Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.DataLakeAnalytics to add version preview/2019-11-01-preview #15893

Merged
merged 4 commits into from
Sep 14, 2021
Merged

[Hub Generated] Review request for Microsoft.DataLakeAnalytics to add version preview/2019-11-01-preview #15893

merged 4 commits into from
Sep 14, 2021

Conversation

jimmyshie123
Copy link
Contributor

@jimmyshie123 jimmyshie123 commented Sep 2, 2021 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @jimmyshie123 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 2, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R4024 - PreviewVersionOverOneYear The API version:2019-11-01-preview having been in a preview state over one year , please move it to GA or retire.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L6


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L635
    ❌ R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L926
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DataLakeAnalytics/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1617
    ❌ R4019 - GetCollectionResponseSchema The response in the GET collection operation 'Accounts_List' does not match the response definition in the individual GET operation 'Accounts_Get' .
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L36
    ❌ R4032 - MissingXmsErrorResponse Response code 404 is defined without a x-ms-error-response.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1679
    ❌ R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1750
    ❌ R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1784
    ❌ R4037 - MissingTypeObject The schema 'DataLakeAnalyticsAccount' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1805
    ❌ R4037 - MissingTypeObject The schema 'DataLakeAnalyticsAccountBasic' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1821
    ❌ R4037 - MissingTypeObject The schema 'DataLakeAnalyticsAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1837
    ❌ R4037 - MissingTypeObject The schema 'DataLakeAnalyticsAccountPropertiesBasic' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2054
    ❌ R4037 - MissingTypeObject The schema 'DataLakeAnalyticsAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2117
    ❌ R4037 - MissingTypeObject The schema 'DataLakeStoreAccountInformation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2135
    ❌ R4037 - MissingTypeObject The schema 'DataLakeStoreAccountInformationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2150
    ❌ R4037 - MissingTypeObject The schema 'DataLakeStoreAccountInformationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2160
    ❌ R4037 - MissingTypeObject The schema 'StorageAccountInformation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2178
    ❌ R4037 - MissingTypeObject The schema 'StorageAccountInformationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2194
    ❌ R4037 - MissingTypeObject The schema 'StorageAccountInformationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2204
    ❌ R4037 - MissingTypeObject The schema 'StorageContainer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2222
    ❌ R4037 - MissingTypeObject The schema 'StorageContainerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2238
    ❌ R4037 - MissingTypeObject The schema 'StorageContainerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2249
    ❌ R4037 - MissingTypeObject The schema 'SasTokenInformation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2267
    ❌ R4037 - MissingTypeObject The schema 'SasTokenInformationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2277
    ❌ R4037 - MissingTypeObject The schema 'ComputePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2295
    ❌ R4037 - MissingTypeObject The schema 'ComputePolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2311
    ❌ R4037 - MissingTypeObject The schema 'ComputePolicyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2350
    ❌ R4037 - MissingTypeObject The schema 'FirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2368
    ❌ R4037 - MissingTypeObject The schema 'FirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2384
    ❌ R4037 - MissingTypeObject The schema 'FirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2399
    ❌ R4037 - MissingTypeObject The schema 'VirtualNetworkRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2431
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 52 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataLakeAnalytics/accounts/{accountName}/DataLakeStoreAccounts/' removed or restructured?
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L435:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataLakeAnalytics/accounts/{accountName}/DataLakeStoreAccounts/{dataLakeStoreAccountName}' removed or restructured?
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L527:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataLakeAnalytics/accounts/{accountName}/StorageAccounts/' removed or restructured?
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L675:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataLakeAnalytics/accounts/{accountName}/StorageAccounts/{storageAccountName}' removed or restructured?
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L767:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'StorageAccountProperties' removed or renamed?
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1749:3
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1771:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'NameParameter' removed or renamed?
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L3449:3
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L3443:3
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_List' to 'Accounts_List'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L38:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L41:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_ListByResourceGroup' to 'Accounts_ListByResourceGroup'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L124:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L127:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_Create' to 'Accounts_Create'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L213:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L308:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_Get' to 'Accounts_Get'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L269:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L216:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_Update' to 'Accounts_Update'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L309:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L368:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_Delete' to 'Accounts_Delete'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L371:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L260:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_ListStorageContainers' to 'StorageAccounts_ListStorageContainers'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L945:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L970:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_GetStorageContainer' to 'StorageAccounts_GetStorageContainer'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L997:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1022:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Account_ListSasTokens' to 'StorageAccounts_ListSasTokens'. This will impact generated code.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1053:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1078:7
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '404'.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1679:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'active, suspended' from the old version.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2084:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L2081:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'active, suspended' from the old version.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2084:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L2081:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'active, suspended' from the old version.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2084:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L2081:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L3160:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L3155:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2897:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L2895:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2904:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L2901:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1972:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1993:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2003:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L2004:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1854:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1871:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L1828:9
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1834:9
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'defaultDataLakeStoreAccount' renamed or removed?
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2055:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1865:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'dataLakeStoreAccounts' renamed or removed?
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2055:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1865:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'publicDataLakeStoreAccounts' renamed or removed?
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2055:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1865:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'storageAccounts' renamed or removed?
    New: Microsoft.DataLakeAnalytics/preview/2019-11-01-preview/account.json#L2055:7
    Old: Microsoft.DataLakeAnalytics/preview/2015-10-01-preview/account.json#L1865:7
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 2, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    This was referenced Sep 2, 2021
    Closed
    Closed
    This was referenced Sep 2, 2021
    Closed
    Closed
    @jimmyshie123 jimmyshie123 marked this pull request as ready for review September 2, 2021 02:57
    @ruowan ruowan assigned leni-msft and unassigned ruowan Sep 2, 2021
    @leni-msft leni-msft assigned jianyexi and unassigned leni-msft Sep 7, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 9, 2021
    @jianyexi jianyexi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 9, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @jimmyshie123 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2021
    majastrz
    majastrz approved these changes Sep 10, 2021
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @jianyexi jianyexi merged commit 42185a2 into Azure:main Sep 14, 2021
    This was referenced Sep 14, 2021
    Merged
    Closed
    Closed
    This was referenced Sep 14, 2021
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 14, 2021
    [ReleasePR datalake-analytics] [Hub Generated] Review request for Mic…
    e607757 
    …rosoft.DataLakeAnalytics to add version preview/2019-11-01-preview (#1902)

Create to sync Azure/azure-rest-api-specs#15893
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/datalake-analytics?expand=1)
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @jimmyshie123 @LeiWang3
    [Hub Generated] Review request for Microsoft.DataLakeAnalytics to add…
    89514ca 
    … version preview/2019-11-01-preview (Azure#15893)

* Adds base for updating Microsoft.DataLakeAnalytics from version stable/2016-11-01 to version 2019-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* test validation patch

Co-authored-by: Jimmy Xie <jimmyxie@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @majastrz majastrz majastrz approved these changes

    @Descatles Descatles Awaiting requested review from Descatles

    Assignees

    @jianyexi jianyexi

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @jimmyshie123 @majastrz @JeffreyRichter @leni-msft @ruowan @jianyexi